Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Remove deprecated and now non-existent flag #7886

Merged
merged 2 commits into from
Apr 4, 2020
Merged

[bazel] Remove deprecated and now non-existent flag #7886

merged 2 commits into from
Apr 4, 2020

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Apr 3, 2020

Why are these changes needed?

Remove a deprecated (since bazel 0.5.3) and now unsupported (since bazel 2.0.0) build flag for bazel. (bazelbuild/bazel@9f9f5ec)

The original file/function that needed this flag that we are pulling from

load("@bazel_common//tools/maven:pom_file.bzl", "pom_file")
has updated the function to use the proper syntax (i.e. to_list()) google/bazel-common@084aadd
As such it is safe to remove this deprecation flag.

Related issue number

Closes #7884
After removing this flag from the .bazelrc ray builds and installs successfully!

Checks

I have also made a commit to update the CI for using the version of pom_file.bzl which contains the fix.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24175/
Test PASSed.

Copy link

@devinbarry devinbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24193/
Test PASSed.

@acxz acxz changed the title remove deprecated and now build breaking flag remove deprecated and now non-existent flag Apr 3, 2020
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution! I'm rerunning the failed/flaky tests to make sure it is unrelated to the upgrade.

@acxz
Copy link
Contributor Author

acxz commented Apr 4, 2020

Just helping out where I can. Thank you guys for maintaining such an amazing project!

@pcmoritz pcmoritz changed the title remove deprecated and now non-existent flag [bazel] Remove deprecated and now non-existent flag Apr 4, 2020
@pcmoritz pcmoritz merged commit 11c2b50 into ray-project:master Apr 4, 2020
@acxz acxz deleted the patch-3 branch April 4, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ray] build error: ERROR: Unrecognized option: --incompatible_depset_is_not_iterable=false
4 participants