Skip to content

Switch Python indentation from 2 spaces to 4 spaces. #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 13, 2017
Merged

Switch Python indentation from 2 spaces to 4 spaces. #726

merged 11 commits into from
Jul 13, 2017

Conversation

robertnishihara
Copy link
Collaborator

@robertnishihara robertnishihara commented Jul 12, 2017 •
edited
Loading

This should address #610.

TODO:

  • Update docs/tutorials/etc to also use four space indentation.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/1267/
Test PASSed.

robertnishihara
robertnishihara commented Jul 12, 2017
View reviewed changes
python/ray/rllib/common.py
"""Initialize an RLLib algorithm.

Args:
env_name (str): The name of the OpenAI gym environment to use.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space indentation here

robertnishihara
robertnishihara commented Jul 12, 2017
View reviewed changes
python/ray/rllib/common.py
"""Runs one logical iteration of training.

Returns:
A TrainingResult that describes training progress.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space here

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/1268/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/1269/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/1284/
Test PASSed.

@pcmoritz pcmoritz merged commit e0867c8 into ray-project:master Jul 13, 2017
@pcmoritz pcmoritz deleted the indentation branch July 13, 2017 21:54
@robertnishihara robertnishihara mentioned this pull request Jul 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertnishihara @AmplabJenkins @pcmoritz