Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply cpython patch bpo-39492 for the reference counting issue in pickle5 #7177

Merged
merged 4 commits into from
Feb 16, 2020

Conversation

suquark
Copy link
Member

@suquark suquark commented Feb 15, 2020

Why are these changes needed?

This should fix cloudpipe/cloudpickle#343 for python3.5, 3.6 and 3.7
It doesn't fix python3.8, but there will be official python3.8.2 fix

Related issue number

Checks

@suquark suquark requested review from edoakes and pcmoritz February 15, 2020 02:07
@suquark
Copy link
Member Author

suquark commented Feb 15, 2020

I think we also need to add a test in Ray, although all tests passed in the upstream

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21969/
Test FAILed.

Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly. This is great.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21987/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21992/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21995/
Test PASSed.

@suquark
Copy link
Member Author

suquark commented Feb 16, 2020

The CI error seems irrelevant. I am going to merge this PR.

@suquark suquark merged commit 6745459 into ray-project:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudpickle_fast causes pickled object to be uncollectable
3 participants