-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply cpython patch bpo-39492 for the reference counting issue in pickle5 #7177
Conversation
I think we also need to add a test in Ray, although all tests passed in the upstream |
Can one of the admins verify this patch? |
Test FAILed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this so quickly. This is great.
Test PASSed. |
Test PASSed. |
Test PASSed. |
The CI error seems irrelevant. I am going to merge this PR. |
Why are these changes needed?
This should fix cloudpipe/cloudpickle#343 for python3.5, 3.6 and 3.7
It doesn't fix python3.8, but there will be official python3.8.2 fix
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.