Render tasks that are not schedulable on the dashboard. #7034

rkooo567 · 2020-02-03T22:45:15Z

Why are these changes needed?

Currently, the dashboard's logical view only renders infeasible tasks (Tasks that will never be able to satisfy its requirement). But we also want to show tasks that are currently not schedulable because there are no available resources. (E.g. There is one gpu available and it is taken by one actor. If you initiate the new actor, it is pending until the first actor is freed). It is not identified as infeasibleTasks. This PR addresses this issue. Look at the picture below for better understanding.

Q&A

Why do you use ready tasks?
Ready tasks are remained in the queue for a long time only if there are no allocatable resources although dependencies are ready. That being said, we can represent WaitUntilResourceAvailable tasks by using ready tasks. This is the core assumption of this PR, so please comment if this assumption is wrong. I commented this workaround solution can be addressed more cleanly by creating a new taskState, WaitUntilResourceAvailable.
Why does it only handle ActorCreationTask?
Currently, the logical view of dashboard only supports ActorCreationTask. Future PRs will address this problem.

Related issue number

RS-726

Test Plan

Manual testing using a script.
Ran test_metrics.py

Checks

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://ray.readthedocs.io/en/latest/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.

…resoureces available (because other actors are occupying them) to the dashboard.

AmplabJenkins · 2020-02-03T22:46:01Z

Can one of the admins verify this patch?

python/ray/dashboard/client/src/pages/dashboard/logical-view/Actor.tsx

python/ray/dashboard/client/src/api.ts

…_tasks

pcmoritz

LGTM, can be merged if the tests pass. I tried it out locally too.

AmplabJenkins · 2020-02-04T03:49:19Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21331/
Test FAILed.

AmplabJenkins · 2020-02-04T05:45:49Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21324/
Test PASSed.

pcmoritz · 2020-02-04T05:49:24Z

@rkooo567 There are some test failures, see e.g. https://travis-ci.com/ray-project/ray/jobs/283233241

AmplabJenkins · 2020-02-04T08:47:27Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21337/
Test FAILed.

AmplabJenkins · 2020-02-04T10:54:26Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21341/
Test PASSed.

rkooo567 · 2020-02-04T22:26:22Z

@pcmoritz The new commit should fix the bug. I will let you know if it passes tests.

python/ray/dashboard/dashboard.py

python/ray/tests/test_metrics.py

src/ray/raylet/node_manager.cc

AmplabJenkins · 2020-02-05T02:54:21Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21397/
Test PASSed.

AmplabJenkins · 2020-02-05T03:33:16Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21402/
Test FAILed.

AmplabJenkins · 2020-02-05T04:34:48Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21403/
Test FAILed.

edoakes · 2020-02-06T18:16:43Z

jenkins retest this please

…_tasks

AmplabJenkins · 2020-02-06T22:31:08Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21517/
Test FAILed.

AmplabJenkins · 2020-02-07T01:58:34Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21521/
Test FAILed.

rkooo567 · 2020-02-07T19:58:20Z

jenkins retest this please

AmplabJenkins · 2020-02-07T21:24:56Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21576/
Test FAILed.

rkooo567 · 2020-02-08T23:42:29Z

jenkins retest this please

…_tasks

AmplabJenkins · 2020-02-09T03:30:41Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21627/
Test PASSed.

AmplabJenkins · 2020-02-09T11:51:42Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21629/
Test FAILed.

rkooo567 · 2020-02-09T17:52:40Z

jenkins retest this please

rkooo567 · 2020-02-10T00:57:28Z

jenkins retest this please

AmplabJenkins · 2020-02-10T04:43:42Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21657/
Test PASSed.

rkooo567 added 7 commits February 3, 2020 00:44

[RS-726]: Render actors that are not schedulable because there is no …

71bdcb1

…resoureces available (because other actors are occupying them) to the dashboard.

fixed formatting

5a4f59c

Fixed a minor issue

2e3cc30

fixing comments

9d2e7ae

adding test

39c2184

Completed writing tests

357693f

Fixed some minor comment

5408ac5

rkooo567 requested review from pcmoritz and edoakes February 3, 2020 22:45

rkooo567 self-assigned this Feb 3, 2020

edoakes changed the title ~~Redner tasks that are not schedulable on the dashboard.~~ Render tasks that are not schedulable on the dashboard. Feb 3, 2020

pcmoritz reviewed Feb 3, 2020

View reviewed changes

python/ray/dashboard/client/src/pages/dashboard/logical-view/Actor.tsx Outdated Show resolved Hide resolved

pcmoritz reviewed Feb 3, 2020

View reviewed changes

python/ray/dashboard/client/src/pages/dashboard/logical-view/Actor.tsx Outdated Show resolved Hide resolved

pcmoritz reviewed Feb 3, 2020

View reviewed changes

python/ray/dashboard/client/src/api.ts Outdated Show resolved Hide resolved

rkooo567 added 3 commits February 3, 2020 16:23

Fix code based on code review.

f2fc8f4

Merge branch 'master' into render_ready_tasks_and_infeasible_creation…

deea559

…_tasks

Fix formatting.

eb2c227

pcmoritz approved these changes Feb 4, 2020

View reviewed changes

rkooo567 added 2 commits February 4, 2020 14:25

Fix the ci bug.

9523621

Fixed linting

8aab301

edoakes approved these changes Feb 4, 2020

View reviewed changes

rkooo567 added 2 commits February 4, 2020 15:57

Fixed code based on the code review.

bdc32b9

Fixed code based on the code review.

ac28699

Improved test util function.

b368c73

Merge branch 'master' into render_ready_tasks_and_infeasible_creation…

5fd554d

…_tasks

Merge branch 'master' into render_ready_tasks_and_infeasible_creation…

f49b219

…_tasks

Fixed a bug caused by ray-project#6709

85cf157

edoakes merged commit 1e69067 into ray-project:master Feb 10, 2020

rkooo567 deleted the render_ready_tasks_and_infeasible_creation_tasks branch February 17, 2022 00:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render tasks that are not schedulable on the dashboard. #7034

Render tasks that are not schedulable on the dashboard. #7034

rkooo567 commented Feb 3, 2020 •

edited

Loading

AmplabJenkins commented Feb 3, 2020

pcmoritz left a comment

AmplabJenkins commented Feb 4, 2020

AmplabJenkins commented Feb 4, 2020

pcmoritz commented Feb 4, 2020

AmplabJenkins commented Feb 4, 2020

AmplabJenkins commented Feb 4, 2020

rkooo567 commented Feb 4, 2020

AmplabJenkins commented Feb 5, 2020

AmplabJenkins commented Feb 5, 2020

AmplabJenkins commented Feb 5, 2020

edoakes commented Feb 6, 2020

AmplabJenkins commented Feb 6, 2020

AmplabJenkins commented Feb 7, 2020

rkooo567 commented Feb 7, 2020

AmplabJenkins commented Feb 7, 2020

rkooo567 commented Feb 8, 2020

AmplabJenkins commented Feb 9, 2020

AmplabJenkins commented Feb 9, 2020

rkooo567 commented Feb 9, 2020

rkooo567 commented Feb 10, 2020

AmplabJenkins commented Feb 10, 2020

Render tasks that are not schedulable on the dashboard. #7034

Render tasks that are not schedulable on the dashboard. #7034

Conversation

rkooo567 commented Feb 3, 2020 • edited Loading

Why are these changes needed?

Related issue number

Test Plan

Checks

AmplabJenkins commented Feb 3, 2020

pcmoritz left a comment

Choose a reason for hiding this comment

AmplabJenkins commented Feb 4, 2020

AmplabJenkins commented Feb 4, 2020

pcmoritz commented Feb 4, 2020

AmplabJenkins commented Feb 4, 2020

AmplabJenkins commented Feb 4, 2020

rkooo567 commented Feb 4, 2020

AmplabJenkins commented Feb 5, 2020

AmplabJenkins commented Feb 5, 2020

AmplabJenkins commented Feb 5, 2020

edoakes commented Feb 6, 2020

AmplabJenkins commented Feb 6, 2020

AmplabJenkins commented Feb 7, 2020

rkooo567 commented Feb 7, 2020

AmplabJenkins commented Feb 7, 2020

rkooo567 commented Feb 8, 2020

AmplabJenkins commented Feb 9, 2020

AmplabJenkins commented Feb 9, 2020

rkooo567 commented Feb 9, 2020

rkooo567 commented Feb 10, 2020

AmplabJenkins commented Feb 10, 2020

rkooo567 commented Feb 3, 2020 •

edited

Loading