Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Bug fix: DQN goes into negative epsilon values after reaching explora… #6971

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 30, 2020

…tion percentage.

DQN goes into negative epsilon values after reaching exploration_percentage. This effectively disables all exploration for the rest of the run (usually, a small epsilon for the rest of the run is desirable, e.g. 0.01/0.02).

Related issue number

Checks

@sven1977 sven1977 requested a review from ericl January 30, 2020 09:56
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21164/
Test FAILed.

@ericl
Copy link
Contributor

ericl commented Jan 30, 2020

LGTM pending tests.

@ericl ericl self-assigned this Jan 30, 2020
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21192/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21196/
Test FAILed.

@sven1977
Copy link
Contributor Author

@ericl RLlib tests are all good.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/21201/
Test PASSed.

@ericl ericl merged commit 2ccf08a into ray-project:master Jan 31, 2020
@sven1977
Copy link
Contributor Author

Thanks!

@sven1977 sven1977 deleted the bug_dqn_exploration_negative_epsilon branch March 3, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants