[GCS] Add async register nodes to GCS Client #6742

micafan · 2020-01-08T04:01:47Z

Why are these changes needed?

Add AsyncRegister to NodeInfoAccessor for GCS Service.

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://ray.readthedocs.io/en/latest/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.

AmplabJenkins · 2020-01-08T04:09:47Z

Can one of the admins verify this patch?

wumuzi520 · 2020-01-08T06:17:12Z

LGTM!

AmplabJenkins · 2020-01-08T09:47:13Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20511/
Test FAILed.

AmplabJenkins · 2020-01-08T10:59:01Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20513/
Test PASSed.

micafan added 2 commits January 8, 2020 11:59

add AsyncRegister to NodeInfoAccessor

a713147

format

8f0d0fc

fix usage of gcs server

0daebf4

micafan changed the title ~~Add async register nodes to GCS Client~~ [GCS]Add async register nodes to GCS Client Jan 8, 2020

micafan changed the title ~~[GCS]Add async register nodes to GCS Client~~ [GCS] Add async register nodes to GCS Client Jan 8, 2020

zhijunfu approved these changes Jan 8, 2020

View reviewed changes

zhijunfu merged commit 1211e6a into ray-project:master Jan 9, 2020

zhijunfu deleted the add_async_register_nodes_to_gcs branch January 9, 2020 02:51