Skip to content

Reducing the size of objects created for the global scheduler test. #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

atumanov
Copy link
Contributor

This addresses #457 by reducing the size of the objects created by the global scheduler test. Prior to this PR, it was possible for the test to create a number of objects that exceeds plasma store capacity, when running on small memory instances (e.g., plasma store with 1GB capacity). This triggered reconstruction, which failed and killed the local scheduler. AS a result, during tearDown, the failure of the local scheduler resulted in a an assertion failure when checking whether all local schedulers are still live.

  • Note that it is impossible for reconstruction to succeed in this case, because all objects are created by the unit test driver.

Testing: no errors or warnings after 94 iterations of the global scheduler test.

$ egrep OK log  |wc -l 
      94
✔ ~/devrepo/github/ray-mydev [globalsched-test-fix L|…850⚑ 14] 
01:38 $ egrep -i warn log  
✘-1 ~/devrepo/github/ray-mydev [globalsched-test-fix L|…850⚑ 14] 
01:38 $ egrep -i error log  
✘-1 ~/devrepo/github/ray-mydev [globalsched-test-fix L|…850⚑ 14] 

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/1032/
Test PASSed.

@robertnishihara robertnishihara changed the title reducing the size of objects created for the global scheduler test Reducing the size of objects created for the global scheduler test. Jun 15, 2017
@robertnishihara robertnishihara merged commit 8317025 into ray-project:master Jun 15, 2017
@robertnishihara robertnishihara deleted the globalsched-test-fix branch June 15, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants