-
Notifications
You must be signed in to change notification settings - Fork 6.8k
workaround for python3.5 fast numpy serialization #6675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
Test PASSed. |
Test FAILed. |
It seems that we have pass all related tests, I can start removing arrow serialization now. |
Test PASSed. |
Test PASSed. |
@pcmoritz I think this PR is ready after the linting. I have removed the pyarrow serialization code path. |
Test PASSed. |
Test PASSed. |
@suquark What's the status of this? Would be awesome to get it merged so that we can remove the pyarrow serialization codepath now that we've dropped python 2 support. |
The PR looks good to me, two things that need to be done before merging:
@suquark Can you test this? |
@pcmoritz I have performed most tests on python3.5, those tests related to this PR works fine; but some other tests failed in some weird ways (pytest fixtures not found, sigabort received, some python dependencies not found, etc). |
I tested the put performance on Python 3.5, which is fast and also ran the tests on 3.5. There are a couple of failures on 3.5 but they all look unrelated. |
Why are these changes needed?
workaround for python3.5 fast numpy serialization, it is necessary for pickle5 support with python3.5
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.