Skip to content

Conversation

suquark
Copy link
Member

@suquark suquark commented Jan 2, 2020

Why are these changes needed?

workaround for python3.5 fast numpy serialization, it is necessary for pickle5 support with python3.5

Related issue number

Checks

@suquark suquark changed the title workaround for python3.5 fast numpy serialization [WIP] workaround for python3.5 fast numpy serialization Jan 2, 2020
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20308/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20428/
Test FAILed.

@suquark
Copy link
Member Author

suquark commented Jan 6, 2020

It seems that we have pass all related tests, I can start removing arrow serialization now.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20426/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20482/
Test PASSed.

@suquark suquark changed the title [WIP] workaround for python3.5 fast numpy serialization workaround for python3.5 fast numpy serialization Jan 7, 2020
@suquark suquark requested a review from pcmoritz January 7, 2020 20:03
@suquark
Copy link
Member Author

suquark commented Jan 7, 2020

@pcmoritz I think this PR is ready after the linting. I have removed the pyarrow serialization code path.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20493/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20494/
Test PASSed.

@edoakes
Copy link
Collaborator

edoakes commented Jan 28, 2020

@suquark What's the status of this? Would be awesome to get it merged so that we can remove the pyarrow serialization codepath now that we've dropped python 2 support.

@pcmoritz
Copy link
Contributor

The PR looks good to me, two things that need to be done before merging:

  • Run the whole test suite on Python 3.5 (Travis is using 3.6)
  • Make sure there is no performance regression on numpy arrays (for Python 3.5, 3.6, 3.7, 3.8).

@suquark Can you test this?

@suquark
Copy link
Member Author

suquark commented Jan 30, 2020

@pcmoritz I have performed most tests on python3.5, those tests related to this PR works fine; but some other tests failed in some weird ways (pytest fixtures not found, sigabort received, some python dependencies not found, etc).
I run these tests using pytest under ray/python after compiling the ray from the source code. And installed it using pip install . -e. Is it the correct way for setting up tests locally?

@pcmoritz
Copy link
Contributor

pcmoritz commented Feb 3, 2020

I tested the put performance on Python 3.5, which is fast and also ran the tests on 3.5. There are a couple of failures on 3.5 but they all look unrelated.

@pcmoritz pcmoritz merged commit 42cbf80 into ray-project:master Feb 3, 2020
@suquark suquark deleted the serialization-python5 branch July 9, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants