Skip to content

[release] Add --no-upgrade to pip-compile args#61770

Open
andrew-anyscale wants to merge 1 commit intoandrew/revup/master/remove-pygithub-cifrom
andrew/revup/master/fix-requirements-update-3
Open

[release] Add --no-upgrade to pip-compile args#61770
andrew-anyscale wants to merge 1 commit intoandrew/revup/master/remove-pygithub-cifrom
andrew/revup/master/fix-requirements-update-3

Conversation

@andrew-anyscale
Copy link
Contributor

Pass --no-upgrade to pip-compile so that regenerating the lockfile only
changes packages that are strictly required by .in file edits, avoiding
incidental upgrades of unrelated transitive dependencies.

Topic: fix-requirements-update-3
Relative: remove-pygithub-ci
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 16, 2026

Reviews in this chain:
#61767 [release] Add GitHubClient: pull request support
 └#61768 [release] Add GitHubClient: issue support
  └#61710 [release] Replace PyGithub with GitHubClient in ray_release
   └#61711 [ci] Replace PyGithub with GitHubClient in get_contributors.py
    └#61770 [release] Add --no-upgrade to pip-compile args
     └#61712 [release] Remove PyGithub from requirements

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 16, 2026

# head base diff date summary
0 f9d1322e 1772209e diff Mar 16 12:41 PM 1 file changed, 1 insertion(+)
1 e7895600 4dfdcd3d rebase Mar 16 12:47 PM 0 files changed
2 794fe424 1775a02b rebase Mar 16 15:17 PM 0 files changed
3 27deb807 f2f15d7f rebase Mar 16 17:22 PM 0 files changed

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/fix-requirements-update-3 branch from f9d1322 to e789560 Compare March 16, 2026 19:47
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the --no-upgrade flag to the pip-compile arguments in release/BUILD.bazel. This is a good practice that prevents pip-compile from upgrading all packages when regenerating the lockfile, instead only updating dependencies that are strictly necessary due to changes in the .in file. This enhances dependency stability and makes updates more predictable. The change is correct and achieves its stated goal. I have no further comments.

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/fix-requirements-update-3 branch from e789560 to 794fe42 Compare March 16, 2026 22:17
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/remove-pygithub-ci branch from 4dfdcd3 to 1775a02 Compare March 16, 2026 22:17
Pass --no-upgrade to pip-compile so that regenerating the lockfile only
changes packages that are strictly required by .in file edits, avoiding
incidental upgrades of unrelated transitive dependencies.

Topic: fix-requirements-update-3
Relative: remove-pygithub-ci
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/remove-pygithub-ci branch from 1775a02 to f2f15d7 Compare March 17, 2026 00:22
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/fix-requirements-update-3 branch from 794fe42 to 27deb80 Compare March 17, 2026 00:22
@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core devprod labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core devprod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants