Skip to content

[release] Restrict requirements_py310 targets to amd64 Linux#61713

Closed
andrew-anyscale wants to merge 1 commit intomasterfrom
andrew/revup/master/fix-requirements-update-2
Closed

[release] Restrict requirements_py310 targets to amd64 Linux#61713
andrew-anyscale wants to merge 1 commit intomasterfrom
andrew/revup/master/fix-requirements-update-2

Conversation

@andrew-anyscale
Copy link
Contributor

Add @platforms//cpu:x86_64 and @platforms//os:linux to exec_compatible_with
so the pip-compile binary and validation test only run on amd64 Linux.

Topic: fix-requirements-update-2
Relative: fix-requirements-update
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 13, 2026

Reviews in this chain:
#61713 [release] Restrict requirements_py310 targets to amd64 Linux

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 13, 2026

# head base diff date summary
0 8f672a92 eb2e201a diff Mar 12 20:21 PM 1 file changed, 10 insertions(+), 2 deletions(-)
1 9d2432c6 8b3f20fd diff Mar 13 9:17 AM 0 files changed
2 459a34e6 2662fb1b rebase Mar 16 8:43 AM 0 files changed
3 9760dfbe 68a622a6 diff Mar 16 10:55 AM 0 files changed

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restricts the requirements_py310.update and requirements_py310_test targets to run only on amd64 Linux by adding constraints to exec_compatible_with. The change is correct and aligns with the goal. I've added one suggestion to improve maintainability by reducing code duplication.

Comment on lines +56 to +60
exec_compatible_with = [
"//bazel:py310",
"@platforms//cpu:x86_64",
"@platforms//os:linux",
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce duplication, consider extracting this exec_compatible_with list into a variable, as it's also used in the requirements_py310.update target above.

For example, you could define a variable before these targets:

_requirements_py310_exec_compatible_with = [
    "//bazel:py310",
    "@platforms//cpu:x86_64",
    "@platforms//os:linux",
]

And then use exec_compatible_with = _requirements_py310_exec_compatible_with in both py_binary and py_test targets.

@ray-gardener ray-gardener bot added the core Issues that should be addressed in Ray Core label Mar 13, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/fix-requirements-update branch from eb2e201 to 8b3f20f Compare March 13, 2026 13:58
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/fix-requirements-update-2 branch 2 times, most recently from 9d2432c to 459a34e Compare March 16, 2026 15:43
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/fix-requirements-update branch from 8b3f20f to 2662fb1 Compare March 16, 2026 15:43
Base automatically changed from andrew/revup/master/fix-requirements-update to master March 16, 2026 16:47
Add @platforms//cpu:x86_64 and @platforms//os:linux to exec_compatible_with
so the pip-compile binary and validation test only run on amd64 Linux.

Topic: fix-requirements-update-2
Relative: fix-requirements-update
Signed-off-by: andrew <andrew@anyscale.com>
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to have conflicts now?

why it needs to be limited to amd64 linux?

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/fix-requirements-update-2 branch from 459a34e to 9760dfb Compare March 16, 2026 17:55
@aslonnie aslonnie enabled auto-merge (squash) March 16, 2026 22:34
@aslonnie aslonnie self-requested a review March 16, 2026 22:34
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Mar 16, 2026
@andrew-anyscale
Copy link
Contributor Author

I was running into issues earlier where greenlit was being removed from the generated file on aarch64, but kept on amd64. I went to repro, and I think it was actually an issue with Python version, as opposed to platform.

This is not the correct fix, so closing.

auto-merge was automatically disabled March 16, 2026 22:55

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants