[release] Restrict requirements_py310 targets to amd64 Linux#61713
[release] Restrict requirements_py310 targets to amd64 Linux#61713andrew-anyscale wants to merge 1 commit intomasterfrom
Conversation
|
Reviews in this chain: |
There was a problem hiding this comment.
Code Review
This pull request restricts the requirements_py310.update and requirements_py310_test targets to run only on amd64 Linux by adding constraints to exec_compatible_with. The change is correct and aligns with the goal. I've added one suggestion to improve maintainability by reducing code duplication.
| exec_compatible_with = [ | ||
| "//bazel:py310", | ||
| "@platforms//cpu:x86_64", | ||
| "@platforms//os:linux", | ||
| ], |
There was a problem hiding this comment.
To improve maintainability and reduce duplication, consider extracting this exec_compatible_with list into a variable, as it's also used in the requirements_py310.update target above.
For example, you could define a variable before these targets:
_requirements_py310_exec_compatible_with = [
"//bazel:py310",
"@platforms//cpu:x86_64",
"@platforms//os:linux",
]And then use exec_compatible_with = _requirements_py310_exec_compatible_with in both py_binary and py_test targets.
eb2e201 to
8b3f20f
Compare
9d2432c to
459a34e
Compare
8b3f20f to
2662fb1
Compare
Add @platforms//cpu:x86_64 and @platforms//os:linux to exec_compatible_with so the pip-compile binary and validation test only run on amd64 Linux. Topic: fix-requirements-update-2 Relative: fix-requirements-update Signed-off-by: andrew <andrew@anyscale.com>
aslonnie
left a comment
There was a problem hiding this comment.
seems to have conflicts now?
why it needs to be limited to amd64 linux?
459a34e to
9760dfb
Compare
|
I was running into issues earlier where This is not the correct fix, so closing. |
Pull request was closed
Add @platforms//cpu:x86_64 and @platforms//os:linux to exec_compatible_with
so the pip-compile binary and validation test only run on amd64 Linux.
Topic: fix-requirements-update-2
Relative: fix-requirements-update
Signed-off-by: andrew andrew@anyscale.com