[Build] Upgrade Bazel from 6.5.0 to 7.5.0#61601
[Build] Upgrade Bazel from 6.5.0 to 7.5.0#61601andrew-anyscale wants to merge 1 commit intomasterfrom
Conversation
|
There was a problem hiding this comment.
Code Review
This pull request upgrades Bazel from version 6.5.0 to 7.5.0. The changes are comprehensive, updating the .bazelversion file, build configurations in .bazelrc and WORKSPACE, and relevant documentation and test files. To maintain compatibility with the existing WORKSPACE-based dependency setup, Bzlmod is disabled. The pull request also includes necessary patches and dependency overrides for rules_apple, apple_support, and protobuf to address breaking changes in Bazel 7. The changes appear correct and well-justified for the upgrade. I have one suggestion to relax the Bazel version pinning in the WORKSPACE file to allow for patch releases, which could improve the developer experience.
3589892 to
ce7d802
Compare
a6fec9c to
d2029f7
Compare
52abc9a to
bb29089
Compare
d2029f7 to
f63c28f
Compare
bb29089 to
5a50d48
Compare
f63c28f to
c8e8439
Compare
5a50d48 to
62db8ee
Compare
62db8ee to
500f21e
Compare
899eb2e to
abcb022
Compare
500f21e to
1d0d801
Compare
abcb022 to
e74b48d
Compare
9915e81 to
c4abe00
Compare
e74b48d to
5114f87
Compare
c4abe00 to
8e29c07
Compare
4b75378 to
bc015e0
Compare
2d3be3e to
faea87e
Compare
bc015e0 to
8883f3c
Compare
faea87e to
a0f915d
Compare
8883f3c to
23fb31c
Compare
Bump the pinned Bazel version to 7.5.0 and add --noenable_bzlmod to keep the existing WORKSPACE-based dependency setup working. Topic: bazel-7-5-upgrade Signed-off-by: andrew <andrew@anyscale.com>
a0f915d to
cf89a0a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| # Our generated CPP template does not work with bazel 7.x , | ||
| # so pin the bazel version to 6 | ||
| USE_BAZEL_VERSION=6.5.0 bash run.sh | ||
| USE_BAZEL_VERSION=7.5.0 bash run.sh |
There was a problem hiding this comment.
Comment contradicts the updated Bazel version pin
Medium Severity
The comment on lines 10-11 explicitly states "Our generated CPP template does not work with bazel 7.x, so pin the bazel version to 6," but USE_BAZEL_VERSION was mechanically changed from 6.5.0 to 7.5.0. If the comment is still accurate, this will break the CPP sanity check. If the template now works with Bazel 7, the comment is stale and misleading. Either way, this looks like an unintentional find-and-replace without verifying the stated incompatibility.


Bump the pinned Bazel version to 7.5.0 and add --noenable_bzlmod to keep the existing WORKSPACE-based dependency setup working.
Topic: bazel-7-5-upgrade
Signed-off-by: andrew andrew@anyscale.com