Skip to content

Conversation

@edoakes
Copy link
Collaborator

@edoakes edoakes commented Jan 30, 2026

This test has been periodically timing out on Windows. New test cases were added in December, so I think we're just bumping up against the 60s limit.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from a team as a code owner January 30, 2026 16:06
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jan 30, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a flaky test, test_get_or_create_actor, which has been timing out on Windows. The change moves the test to a medium-sized test group in the Bazel build configuration, effectively increasing its time limit. This is a reasonable solution for the described problem. The change is simple, correct, and maintains the alphabetical order of the test lists in python/ray/tests/BUILD.bazel. I have no further comments.

@Kunchd
Copy link
Contributor

Kunchd commented Jan 30, 2026

I was looking at this test file, and I feel that there are also tests within the file that can be rewritten as a c++ unit test instead of hoping that a race condition is triggered (e.g. https://github.com/ray-project/ray/blob/master/python/ray/tests/test_get_or_create_actor.py#L104-L120).

I'm currently working on rewriting the linked test, but feel free to merge if this is urgent.

@edoakes
Copy link
Collaborator Author

edoakes commented Jan 30, 2026

I was looking at this test file, and I feel that there are also tests within the file that can be rewritten as a c++ unit test instead of hoping that a race condition is triggered (e.g. https://github.com/ray-project/ray/blob/master/python/ray/tests/test_get_or_create_actor.py#L104-L120).

I'm currently working on rewriting the linked test, but feel free to merge if this is urgent.

Makes sense, but let's merge this change to deflake immediately. You can change it back to small once you cull some of the Python tests.

Copy link
Contributor

@Kunchd Kunchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll move the test back to small after the prune PR.

@edoakes edoakes merged commit 533fa7b into ray-project:master Jan 30, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants