-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[data][llm][doc] Add in resiliency section and refine doc code #60594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
17bbbed to
d4f0aee
Compare
…behavior Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
d4f0aee to
f9436c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
| ds = ray.data.read_parquet(input_path) | ||
| ds = processor(ds) | ||
| ds.write_parquet(output_path) | ||
| # __checkpoint_usage_example_end__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checkpoint demo runs during module import
High Severity
The new checkpoint example executes at import time: it deletes and recreates /tmp/llm_checkpoint_demo/*, sets global ray.data.DataContext checkpoint config, then calls ray.data.read_parquet(input_path) and write_parquet(output_path) without creating any input data. This can fail CI/docs builds and introduces unexpected filesystem and global state side effects.
|
|
||
| # __checkpoint_usage_example_start__ | ||
| processor_config = vLLMEngineProcessorConfig( | ||
| model_source="Qwen/Qwen3-0.6B", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| model_source="Qwen/Qwen3-0.6B", | |
| model_source="unsloth/Llama-3.1-8B-Instruct", |



Description
chat_template_stage=Trueoverapply_chat_template=True)Related issues
Additional information