-
Notifications
You must be signed in to change notification settings - Fork 7.2k
feat(ci): add wandaspecs for local discovery #60563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: andrew/revup/master/refac-names
Are you sure you want to change the base?
feat(ci): add wandaspecs for local discovery #60563
Conversation
Pre-req to local wheel+image building using Wanda. This will allow spec discovery to source pre-req images for the wheel. Topic: wanda-specs Relative: refac-names Signed-off-by: andrew <andrew@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a .wandaspecs configuration file to enable local discovery of Wanda specs for building wheels and images. The change is straightforward, adding a single file that points to the ci/docker/ directory where .wanda.yaml spec files are located. The new file is well-commented, explaining its purpose and the behavior of the Wanda tool. The change appears correct and aligns with the goal described in the pull request. I have reviewed the changes and found no issues.
1a87b8b to
6f41910
Compare
.wandaspecs
Outdated
| ci/docker/ray-wheel.wanda.yaml | ||
| ci/docker/ray-core.wanda.yaml | ||
| ci/docker/ray-java.wanda.yaml | ||
| ci/docker/ray-dashboard.wanda.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we support dir scanning? why does this need to be specific filenames?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See PR description:
Right now, using as an allow-list due to images conflicting with the same name:
[2026-01-28T16:38:16Z] 2026/01/28 16:38:16 build dep graph: load deps: discover specs in ci/docker/: multiple specs have name "corebuild-py3.10": ci/docker/core.build.wanda.yaml, ci/docker/llm.build.wanda.yaml, ci/docker/ml.build.wanda.yaml, ci/docker/rllib.build.wanda.yaml
[2026-01-28T16:38:16Z] 🚨 Error: The command exited with status 1
It's because the wanda files raised in the error message all share the same name attribute of name: "$IMAGE_TO", so spec discovery cannot successfully tie a single name -> Wanda Spec. This property is required, since the discovery uses the name to resolve building pre-req images of form cr.ray.io/rayproject/{name}
I'll need to either revisit that requirement for discovery, or refactor those wandafiles to have differing names (at the very least environment variables)
ray/ci/docker/core.build.wanda.yaml
Lines 1 to 2 in 48c15d1
| name: "$IMAGE_TO" | |
| froms: ["$IMAGE_FROM"] |
ray/ci/docker/llm.build.wanda.yaml
Lines 1 to 2 in 48c15d1
| name: "$IMAGE_TO" | |
| froms: ["$IMAGE_FROM"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
performed the refactor at #60596
6f41910 to
bce3570
Compare
Pre-req to local wheel+image building using Wanda. This will allow spec discovery to source pre-req images for the wheel.
Topic: wanda-specs
Relative: refac-names
Signed-off-by: andrew andrew@anyscale.com