Skip to content

Conversation

@andrew-anyscale
Copy link
Contributor

@andrew-anyscale andrew-anyscale commented Jan 28, 2026

Pre-req to local wheel+image building using Wanda. This will allow spec discovery to source pre-req images for the wheel.

Topic: wanda-specs
Relative: refac-names
Signed-off-by: andrew andrew@anyscale.com

Pre-req to local wheel+image building using Wanda. This will allow spec discovery to source pre-req images for the wheel.

Topic: wanda-specs
Relative: refac-names
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Jan 28, 2026

Reviews in this chain:
#60596 refactor(ci): Unique env name for images
 └#60563 feat(ci): add wandaspecs for local discovery
  └#60564 feat(build): add container-resource-utils
   └#60565 feat(build): add build-wheel.sh script for local wheel generation

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Jan 28, 2026

# head base diff date summary
0 1a87b8b8 23402617 diff Jan 28 8:22 AM 1 file changed, 10 insertions(+)
1 6f419104 23402617 diff Jan 28 9:45 AM 1 file changed, 5 insertions(+), 1 deletion(-)
2 bce35700 742e9a61 diff Jan 29 18:25 PM 1 file changed, 1 insertion(+), 5 deletions(-)

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a .wandaspecs configuration file to enable local discovery of Wanda specs for building wheels and images. The change is straightforward, adding a single file that points to the ci/docker/ directory where .wanda.yaml spec files are located. The new file is well-commented, explaining its purpose and the behavior of the Wanda tool. The change appears correct and aligns with the goal described in the pull request. I have reviewed the changes and found no issues.

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-specs branch from 1a87b8b to 6f41910 Compare January 28, 2026 17:45
@ray-gardener ray-gardener bot added the devprod label Jan 28, 2026
.wandaspecs Outdated
Comment on lines 11 to 14
ci/docker/ray-wheel.wanda.yaml
ci/docker/ray-core.wanda.yaml
ci/docker/ray-java.wanda.yaml
ci/docker/ray-dashboard.wanda.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we support dir scanning? why does this need to be specific filenames?

Copy link
Contributor Author

@andrew-anyscale andrew-anyscale Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR description:

Right now, using as an allow-list due to images conflicting with the same name:
[2026-01-28T16:38:16Z] 2026/01/28 16:38:16 build dep graph: load deps: discover specs in ci/docker/: multiple specs have name "corebuild-py3.10": ci/docker/core.build.wanda.yaml, ci/docker/llm.build.wanda.yaml, ci/docker/ml.build.wanda.yaml, ci/docker/rllib.build.wanda.yaml
[2026-01-28T16:38:16Z] 🚨 Error: The command exited with status 1

It's because the wanda files raised in the error message all share the same name attribute of name: "$IMAGE_TO", so spec discovery cannot successfully tie a single name -> Wanda Spec. This property is required, since the discovery uses the name to resolve building pre-req images of form cr.ray.io/rayproject/{name}

I'll need to either revisit that requirement for discovery, or refactor those wandafiles to have differing names (at the very least environment variables)

name: "$IMAGE_TO"
froms: ["$IMAGE_FROM"]

name: "$IMAGE_TO"
froms: ["$IMAGE_FROM"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performed the refactor at #60596

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-specs branch from 6f41910 to bce3570 Compare January 30, 2026 02:25
@andrew-anyscale andrew-anyscale requested a review from a team as a code owner January 30, 2026 02:25
@andrew-anyscale andrew-anyscale changed the base branch from master to andrew/revup/master/refac-names January 30, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants