Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CoreWorkerTaskExecutionInterface #6009

Merged
merged 34 commits into from
Oct 25, 2019
Merged

Remove CoreWorkerTaskExecutionInterface #6009

merged 34 commits into from
Oct 25, 2019

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Oct 25, 2019

Why are these changes needed?

Simplifies the code.

Related issue number

Checks

edoakes and others added 24 commits October 23, 2019 12:04
@edoakes
Remove task_context
649ad0f
@edoakes
Use core worker job ID
d656bae
@edoakes
Fix put_object calls
849b1e6
@edoakes
Remove compute_put_id
c6fb56e
@edoakes
Postcrement
b7c034c
@edoakes
Temporary fix
818a7a3
@edoakes
Fix memory limits
34b45d2
@edoakes
Fix already exists check
7009cf8
@edoakes
move actor_id into core worker
15c457f
@edoakes
Remove setters from cython
ed3d914
@edoakes
Add multithreading warning in C++
e77aa6f
@edoakes
Fix multithreading warning
306c9de
@edoakes
Fix core worker test
e071cac
@pcmoritz @edoakes
Reduce actor submission python overhead (ray-project#5949)
3d3f6c2
@ericl @edoakes
rllib] Fix leak of TensorFlow assign operations in DQN/DDPG
742e1dc
@edoakes
Update release doc (ray-project#5988)
f6a353e 
* Update release doc

* Add comment about get_contributors.py
@edoakes
Ignore errors in ObjectID.__dealloc__ (ray-project#5997)
7b8021b
@edoakes
Update profiling numbers (ray-project#5989)
28e3cc5
@edoakes
fix comment (ray-project#6006)
005f7d4
@edoakes
Use core_worker_ field
2c94023
@edoakes
Move even more into core worker
2138b17
@edoakes
Move ExecuteTask
fda4ad3
@edoakes
Remove TaskExecutionInterface
39a5d78
@edoakes
Remove object interface unique_ptr
7f8a9bb
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17889/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17890/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17886/
Test FAILed.

stephanie-wang
stephanie-wang requested changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@stephanie-wang stephanie-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left some comments for further cleanup, but if they're not doable, let's merge it.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17895/
Test FAILed.

stephanie-wang
stephanie-wang approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@stephanie-wang stephanie-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay :)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17899/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17894/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17898/
Test FAILed.

@edoakes edoakes merged commit d4055d7 into ray-project:master Oct 25, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17901/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanie-wang stephanie-wang stephanie-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edoakes @AmplabJenkins @stephanie-wang @pcmoritz @ericl