Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn processes in background sessions #6008

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Oct 25, 2019

Why are these changes needed?

Currently ray.init() spawns child processes and leaves them in the foreground process session group, which means ctrl-c is propagated to them. This causes redis to crash, so we don't gracefully handle KeyboardInterrupts in interactive python shells.

Related issue number

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pcmoritz
Copy link
Contributor

Horay!

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17882/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17887/
Test FAILed.

@edoakes edoakes merged commit f8a6ed7 into ray-project:master Oct 25, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/17900/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants