[ci] Update RayCI to 0.25.0 and switch to test rules files

[andrew-anyscale]

• Bump .rayciversion from 0.21.0 to 0.25.0
• Move rules files to .buildkite/ with *.rules.txt naming convention
• Add always.rules.txt for always-run lint rules
• Add test.rules.test.txt with test cases
• Add test-rules CI step in cicd.rayci.yml (auto-discovery)
• Update macOS config to use new rules file paths

Topic: update-rayci-latest

Signed-off-by: andrew andrew@anyscale.com

[andrew-anyscale]

Reviews in this chain:
└#59987 [ci] Update RayCI to 0.25.0 and switch to test rules files

[andrew-anyscale]

#	head	base	diff	date	summary
0	c9ecb362	8590bc8b	diff	Jan 8 17:14 PM	4 files changed, 29 insertions(+), 4 deletions(-)
1	0d2fd1b6	8590bc8b	diff	Jan 8 17:21 PM	1 file changed, 1 insertion(+)
2	447ce998	8590bc8b	diff	Jan 8 17:36 PM	2 files changed, 95 insertions(+)
3	b87aa7eb	8590bc8b	diff	Jan 12 10:54 AM	6 files changed, 4 insertions(+), 6 deletions(-)
4	30688c1e	8590bc8b	diff	Jan 12 10:56 AM	1 file changed, 1 insertion(+)
5	4627cda9	8590bc8b	diff	Jan 12 11:36 AM	2 files changed, 50 insertions(+), 40 deletions(-)
6	e7f99d25	8590bc8b	diff	Jan 12 11:51 AM	1 file changed, 4 deletions(-)
7	29366717	8590bc8b	diff	Jan 12 12:04 PM	1 file changed, 5 insertions(+), 5 deletions(-)
8	15942832	8590bc8b	diff	Jan 12 12:39 PM	1 file changed, 259 insertions(+)
9	1d8460ef	8590bc8b	diff	Jan 12 12:47 PM	2 files changed, 2 insertions(+), 2 deletions(-)
10	30ad7890	8590bc8b	diff	Jan 12 13:31 PM	1 file changed, 1 insertion(+), 259 deletions(-)
11	84aee69d	8590bc8b	diff	Jan 12 13:36 PM	1 file changed, 265 insertions(+), 1 deletion(-)
12	f7867c20	8590bc8b	diff	Jan 12 14:29 PM	5 files changed, 6 insertions(+), 2 deletions(-)
13	e749e007	8590bc8b	diff	Jan 12 16:40 PM	4 files changed, 531 deletions(-)
14	976d532d	8590bc8b	diff	Jan 12 16:46 PM	1 file changed, 1 deletion(-)
15	28f37cb8	8590bc8b	diff	Jan 12 17:41 PM	1 file changed, 1 insertion(+), 2 deletions(-)

[gemini-code-assist]

Code Review

This pull request updates RayCI to version 0.24.0 and refactors the CI configuration for macOS to use test_rules_files. The changes correctly separate the 'always lint' rules into a new file and add a catch-all rule to handle previously unhandled files. However, there is a critical oversight in the macOS configuration where the new test_rules_always.txt file is not included, which would likely result in linting tests not being run. I've provided a specific comment with a suggestion to fix this.

[aslonnie]

is this file still required? or should this be symlinked now?

[andrew-anyscale]

We can get rid of it if we also get rid of test_conditional_testing

ray/ci/pipeline/BUILD.bazel

Line 15 in fcde85e

":test_rules.txt",

I wasn't sure if we wanted to do that in a separate PR or not

[aslonnie]

ok.

a separate PR or not
up to you. if this file is not used anymore, we do not have to keep it. we can remove the test all together.

[aslonnie]

just symlink these files into .buildkite/macos/ directory?

[aslonnie]

what I meant is that, once those are symlinked, we do not need to list them here? since they are in the buildkite dir now, and will be picked up automatically?

[andrew-anyscale]

Ahhh yes, you're absolutely right since it's pikced up by

buildkite_dirs:
  - .buildkite/macos

Let me clean this line up

[aslonnie]

ok.

a separate PR or not
up to you. if this file is not used anymore, we do not have to keep it. we can remove the test all together.

[aslonnie]

linter failing?

[andrew-anyscale]

eek forgot to hit the push. Linter should be good to go now 👍