[train][jax] skipping jax test in test_backend #58994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a test failure for test_jax_distributed_shutdown_timeout on Python 3.12+ by skipping the test. The underlying issue is that the jax version used in the test environment is incompatible with Python 3.12. The change is appropriate. I have one minor suggestion to improve the clarity of the skip reason for future maintainability.
| @pytest.mark.parametrize("timeout_s", [5, 0]) | ||
| @pytest.mark.skipif( | ||
| sys.version_info >= (3, 12), | ||
| reason="Current jax version is not supported in python 3.12+", |
Contributor
There was a problem hiding this comment.
For better maintainability, could you make the reason a bit more specific? Based on the PR description, the jax version is constrained by the test environment. A more descriptive reason would be helpful for future developers who might need to revisit this.
Suggested change
| reason="Current jax version is not supported in python 3.12+", | |
| reason="jax<=0.4.14, used in this test env, is not supported on Python 3.12+", |
liulehui
approved these changes
Nov 26, 2025
aslonnie
approved these changes
Nov 26, 2025
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
Jax dependency is introduced in ray-project#58322 The current test environment is for CUDA 12.1, which limit jax version below 0.4.14. jax <= 0.4.14 does not support py 3.12. skip jax test if it runs against py3.12+. Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jax dependency is introduced in #58322
The current test environment is for CUDA 12.1, which limit jax version below 0.4.14.
jax <= 0.4.14 does not support py 3.12.
skip jax test if it runs against py3.12+.