[data][dashboard] Add time_to_first_batch and get_ref_bundles to data dashboard attempt 2 #58912
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_bundles… (ray-project#58911)" This reverts commit e882d2d. Signed-off-by: Timothy Seah <tseah@anyscale.com>
Signed-off-by: Timothy Seah <tseah@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds two new panels, 'Iteration Time to First Batch' and 'Iteration Get Ref Bundles Time', to the Ray Data dashboard. The changes are straightforward and correctly add the new panels to the UI. I have a couple of suggestions regarding the Prometheus queries. If the underlying metrics are counters, which is a common convention for metrics ending in _seconds, using increase() would make the graphs more informative by showing changes over time intervals rather than a cumulative total. If they are gauges, the current implementation is correct.
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Show resolved
Hide resolved
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Show resolved
Hide resolved
alanwguo
approved these changes
Nov 22, 2025
ray-gardener
bot
added
data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed panel id's to avoid merge conflicts