-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[ml] train/tune: migrate most of the tests to run on python 3.10 #58902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates most of the ML tests in the Buildkite CI pipeline from Python 3.9 to 3.10. The changes involve updating Python version matrices, hardcoding Python 3.10 in various test steps, and adjusting build dependencies. Overall, the changes are consistent with the goal of the PR. I've found one critical typo in a dependency name that needs to be corrected to prevent CI failures.
.buildkite/ml.rayci.yml
Outdated
| --parallelism-per-worker 3 | ||
| --skip-ray-installation | ||
| depends_on: [ "mlbuild", "forge" ] | ||
| depends_on: [ "mlbuild-multiply", "forge" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.buildkite/ml.rayci.yml
Outdated
| --parallelism-per-worker 3 | ||
| --skip-ray-installation | ||
| depends_on: [ "mlbuild", "forge" ] | ||
| depends_on: [ "mlbuild-multiply", "forge" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Typo in dependency name
The depends_on field references mlbuild-multiply instead of mlbuild-multipy. This typo causes the doc tests job to depend on a non-existent build step, which will prevent the pipeline from running correctly. The correct build name is mlbuild-multipy as defined earlier in the file and used consistently in all other test jobs.
ad575cb to
7272000
Compare
stop running on python 3.9 any more Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
622182b to
e093586
Compare
|
@matthewdeng @justinvyu do you know how to fix the following error when upgraded to python 3.10? |
stop running on python 3.9 any more