[Data] - Fix test_expression_evaluator #57848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutam <goutam@anyscale.com>
goutamvenkat-anyscale
added
go
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the expression evaluator concerning the is_in operation. The changes correctly replace the erroneous .is_in() method call on PyArrow expression objects with the appropriate pyarrow.compute.is_in function. This correction is applied to both the in operator within comparison expressions and the is_in function call handler. The fix is accurate and effectively resolves the described issue.
alexeykudinkin
approved these changes
Oct 17, 2025
bveeramani
reviewed
Oct 17, 2025
|
|
||
| comparators = [self.visit(comp) for comp in node.comparators] | ||
|
|
||
| op = node.ops[0] |
There was a problem hiding this comment.
Can you remove test_expression_evaluator.py from semgrep.yml, and also add the pytest.main to the bottom of test_expression_evaluator.py?
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
python/ray/data/_internal/planner/plan_expression/expression_evaluator.py
Show resolved
Hide resolved
bveeramani
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old expression evaluator did not correctly handle
is_inwhich failed tests intest_expression_evaluatorRelated issues
Fixes #57820
Additional information