deflake autoscaling basic with min aggregation #57784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flaky test
What I think is the likely cause
When using
RAY_SERVE_AGGREGATE_METRICS_AT_CONTROLLER=1
withmin
aggregation:Replicas emit metrics at slightly different times (even if just 10ms apart due to the timestamp bucketing/rounding)
The merged timeseries reflects the ramp-up:
min
aggregation captures the starting point:aggregate_timeseries(..., aggregation_function="min")
takes the minimum value from the merged timeseriesRemoving min from test fixture.
I think a more robust solution is to keep the last report in the controller, generate the final time series using both reports, then clip the data and mid-point, then apply the aggregation function.