-
Notifications
You must be signed in to change notification settings - Fork 6.9k
add docs for post API #57698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs for post API #57698
Conversation
Signed-off-by: harshit <harshit@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the new External Scaling Webhook feature. The new documentation page provides a good overview, API reference, and a Python example. I've suggested a couple of improvements to the example code to make it more robust by adding a request timeout and using a more general success check. The other changes to index and config files look good.
Signed-off-by: harshit <harshit@anyscale.com>
angelinalg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature!
abrarsheikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my high level feedback
- this content should be part of https://docs.ray.io/en/master/serve/advanced-guides/advanced-autoscaling.html, specifically after
Custom autoscaling policies. This will make it easier to tie a story aroundexternal scalerand why its needed. - The document is too verbose and can be condensed.
Co-authored-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
abrarsheikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you confirm that the example work if I try to run it as is following the documentation?
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
|
@cursoragent can you please fix the unresolved review comments on the latest changes? |
|
Perfect! I've successfully addressed all the unresolved review comments on your PR. Here's a summary of the changes I made: Changes Made:1. Fixed bug in
|
Co-authored-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
Signed-off-by: harshit <harshit@anyscale.com>
| - **Query current replica count**: You can get the current number of replicas for any deployment by querying the GET `/applications` API: | ||
|
|
||
| ```bash | ||
| curl -X GET http://localhost:8265/api/serve/applications/ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this trailing backslash intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
adding docs for POST API, here are more details: https://docs.google.com/document/d/1KtMUDz1O3koihG6eh-QcUqudZjNAX3NsqqOMYh3BoWA/edit?tab=t.0#heading=h.2vf4s2d7ca46
also, making changes for the external scaler enabled in the existing serve application docs
to be merged after #57554