[release test] move in join_cloud_storage_paths

[aslonnie]

into anyscale_job_runner. it is only used in anyscale_job_runner now

[gemini-code-assist]

Code Review

This pull request refactors the codebase by moving the join_cloud_storage_paths function from the general util module to the anyscale_job_runner module, where it is exclusively used. This is a good change that improves modularity. I've added a review comment to improve the implementation of the moved function, making it more robust against edge cases and more Pythonic.

[gemini-code-assist]

The current implementation of _join_cloud_storage_paths has a couple of potential issues and can be simplified.

1. Potential IndexError: The expression paths[i][0] will raise an IndexError if paths[i] is an empty string. Similarly, joined_path[-1] will raise an IndexError if os.path.join returns an empty string (e.g., if no paths are provided).
2. Inefficient string manipulation: The while loops for stripping leading and trailing slashes can be replaced with the more idiomatic and efficient lstrip('/') and rstrip('/') string methods.

Here is a suggested improvement that addresses these points, making the function more robust and Pythonic.

Suggested change

	def _join_cloud_storage_paths(*paths: str):
	paths = list(paths)
	if len(paths) > 1:
	for i in range(1, len(paths)):
	while paths[i][0] == "/":
	paths[i] = paths[i][1:]
	joined_path = os.path.join(*paths)
	while joined_path[-1] == "/":
	joined_path = joined_path[:-1]
	return joined_path
	def _join_cloud_storage_paths(*paths: str):
	path_list = list(paths)
	if len(path_list) > 1:
	for i in range(1, len(path_list)):
	path_list[i] = path_list[i].lstrip("/")
	joined_path = os.path.join(*path_list)
	return joined_path.rstrip("/")