[release test] let custom byod tests only depend on the binary file #57663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes typo in build file Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
added
alpha
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several good improvements. It refactors the Bazel dependencies for test_custom_byod_build and test_custom_image_build_and_test_init by removing redundant direct dependencies on :ray_release, making the build definitions cleaner. It also corrects a typo in a dependency label in release/BUILD.bazel and applies PEP 8 compliant formatting to the import statements in two Python test files. The changes are correct and enhance code maintainability.
harshit-anyscale
pushed a commit
that referenced
this pull request
Oct 15, 2025
…57663) also fixes typo in build file Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…ay-project#57663) also fixes typo in build file Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…ay-project#57663) also fixes typo in build file Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
…57663) also fixes typo in build file Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…ay-project#57663) also fixes typo in build file Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…ay-project#57663) also fixes typo in build file Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes typo in build file