Skip to content

[core] Making MacOS + Java tests a little less unpleasant #57627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[core] Making MacOS + Java tests a little less unpleasant #57627

wants to merge 2 commits into from
+2 −55

Conversation

israbbani
Copy link
Contributor

@israbbani israbbani commented Oct 10, 2025 •
edited
Loading

The MacOS + Java CI takes up a lot of time to debug. Here are a few improvements

  • Removing logic to find the network interface on the machine. It fails if we have different interfaces that the test expects. Instead, we can just let ray use loclahost.
  • Deleting a test that just spams log lines to buildkite output. It's to test log4j performance, but it doesn't assert anything.

@israbbani
[do-not-merge] debugging macos tests
c4c8e7a 
Signed-off-by: irabbani <israbbani@gmail.com>
@israbbani israbbani added the go add ONLY when ready to merge, run all tests label Oct 10, 2025
@israbbani
[core] Making MacOS + Java CLI a little less miserable
b5b8a14 
- removing logic that tries to find the machine's ip address. Let ray
  use localhost.
- removing a test that just logs out 2,000,000 lines in an actor and
  then prints how long it took. No assertions...

Signed-off-by: irabbani <israbbani@gmail.com>
@israbbani israbbani changed the title [do-not-merge] debugging macos tests [core] Making MacOS + Java tests a little less unpleasant Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfstorm kfstorm Awaiting requested review from kfstorm kfstorm will be requested when the pull request is marked ready for review kfstorm is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen will be requested when the pull request is marked ready for review raulchen is a code owner

@WangTaoTheTonic WangTaoTheTonic Awaiting requested review from WangTaoTheTonic WangTaoTheTonic will be requested when the pull request is marked ready for review WangTaoTheTonic is a code owner

@SongGuyang SongGuyang Awaiting requested review from SongGuyang SongGuyang will be requested when the pull request is marked ready for review SongGuyang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@israbbani