[rllib] Fix segment_tree.py edge case #57599
Open
+54
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
SegmentTree
is a component of the rllibPrioritizedEpisodeReplayBuffer
however for extreme edge case prefix sum values thenfind_prefixsum_idx
will return invalid out of bounds value.I couldn't find a bug, rather if the
prefixsum_value
is equal to theSegmentTree.sum()
then traversing down the tree could cause it to return invalid indexes.I've added unittests to reproduce the original error and check against it
Related issue number
Close #54284
Checks
git commit -s
) in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.