-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[release] Hello world test for Azure #57597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khluu
wants to merge
21
commits into
master
Choose a base branch
from
khluu/azure_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
01f012e
p
khluu 4657c9c
p
khluu 7fa39d6
p
khluu 9f038cf
Merge branch 'master' into khluu/azure_working_dir
khluu a258168
p
khluu 010f583
p
khluu b1f10af
Merge branch 'master' into khluu/azure_working_dir
khluu 728be9d
p
khluu 6772985
p
khluu 087ed03
p
khluu a2fe6a0
Merge branch 'khluu/azure_working_dir' into khluu/azure_test
khluu c30e864
p
khluu 8364933
p
khluu e65538d
p
khluu ba1b06c
p
khluu f8f6d0b
test
khluu a0cf6bb
p
khluu 481249d
Merge branch 'khluu/azure_working_dir' into khluu/azure_test
khluu af82f30
merge
khluu 184a5a5
p
khluu 5c65e4f
p
khluu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
release/hello_world_tests/hello_world_compute_config_azure.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
cloud_id: {{env["ANYSCALE_CLOUD_ID"]}} | ||
region: us-west-2 | ||
|
||
head_node_type: | ||
name: head_node | ||
instance_type: 4CPU-16GB | ||
|
||
worker_node_types: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
ANYSCALE_HOST=https://console.anyscale-staging.com | ||
RELEASE_AWS_ANYSCALE_SECRET_ARN="arn:aws:secretsmanager:us-west-2:029272617770:secret:release-automation/anyscale-staging-token20231008005227440600000001-JTgxb0" | ||
RELEASE_DEFAULT_CLOUD_ID="cld_5nnv7pt2jn2312x2e5v72z53n2" | ||
RELEASE_DEFAULT_PROJECT="prj_y8syktydl7ltabhz5axdelwnce" | ||
ANYSCALE_CLOUD_STORAGE_PROVIDER=abfss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Azure Blob Storage URL Scheme Issue
The update to the storage service detection logic removes support for
abfss://
URLs. Whileurlparse().scheme
correctly identifiesabfss
for these URLs, theelif
condition now expectsazure_blob
, which is only set for a specifichttps://
pattern. This causesabfss://
URLs to fall through to an unsupported storage service exception.