Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Modin from Ray wheels. #5647

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

devin-petersohn
Copy link
Member

There are several reasons for this:

  • We no longer support python2
  • There should be only 1 way of installing Modin
    • Issue management on these wheels
  • I have never heard of anyone using this feature
  • It is rarely kept up to date
  • Modin depends on specific versions of Ray because of past API changes

Why are these changes needed?

Related issue number

Checks

There are several reasons for this:

* We no longer support python2
* There should be only 1 way of installing Modin
  * Issue management on these wheels
* I have never heard of anyone using this feature
* It is rarely kept up to date
* Modin depends on specific versions of Ray because of past API changes
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16826/
Test PASSed.

Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compelling reason, agreed.

@simon-mo simon-mo merged commit c33d666 into ray-project:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants