Remove Redis version from Linux scripts #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cd redis-3.2.3 | ||
| if [ ! -f redis/src/redis-server ]; then | ||
| redis_vname="redis-3.2.3" | ||
| if [ ! -f redis/utils/whatisdoing.sh ]; then |
There was a problem hiding this comment.
What is this for?
There was a problem hiding this comment.
Haha sorry, I should've explained. It's one of the last files in the tarball, so it's to check the tarball has been extracted fully (and not terminated halfway). The whole PR is because I ran the script multiple times and it didn't really seem idempotent (it'd name the second tarball to <name>.1 or something) and didn't seem to run properly so I just removed the temporary copy altogether (and stripped the outer directory directly).
There was a problem hiding this comment.
Ok that makes sense.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not required per se, but version numbers aren't necessary at all (and shouldn't need to be sprinkled across multiple scripts).