Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] Enable object store memory limit by default #5534

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Aug 25, 2019

Why are these changes needed?

Since rllib really doesn't use large amounts of object store memory, set low limits by default.

Related issue number

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@richardliaw
Copy link
Contributor

Wait, does that mean I can set the same thing for Tune?

@ericl
Copy link
Contributor Author

ericl commented Aug 25, 2019

Yeah, you can set it as part of / the default for resources_per_trial. The plumbing for Tune support is all there which is what rllib is leveraging here.

@ericl
Copy link
Contributor Author

ericl commented Aug 25, 2019

(to be clear, don't mess with ray.init, that's auto-detected. Just set it in per_trial_resources).

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16529/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16530/
Test PASSed.

@ericl ericl force-pushed the enable-rllib-mem branch from ce199d3 to 9837c79 Compare August 25, 2019 23:42
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16532/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16533/
Test PASSed.

@ericl ericl merged commit 97ccd75 into ray-project:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants