comments

doc/source/autoscaling.rst

@@ -79,7 +79,7 @@ Test that it works by running the following commands from your local machine:
     $ kubectl -n ray get pods
 
     # Get a remote screen on the head node.
-    $ ray attach ray/python/ray/autoscaler/gcp/example-full.yaml
+    $ ray attach ray/python/ray/autoscaler/kubernetes/example-full.yaml
     $ # Try running a Ray program with 'ray.init(address="localhost:6379")'.
 
     # Tear down the cluster

python/ray/autoscaler/autoscaler.py

@@ -77,7 +77,7 @@
             "head_ip": (str, OPTIONAL),  # local cluster head node
             "worker_ips": (list, OPTIONAL),  # local cluster worker nodes
             "use_internal_ips": (bool, OPTIONAL),  # don't require public ips
-            "namespace": (dict, OPTIONAL),  # k8s namespace, if using k8s
+            "namespace": (str, OPTIONAL),  # k8s namespace, if using k8s
 
             # k8s autoscaler permissions, if using k8s
             "autoscaler_service_account": (dict, OPTIONAL),

python/ray/autoscaler/kubernetes/node_provider.py

@@ -24,7 +24,7 @@ class KubernetesNodeProvider(NodeProvider):
     def __init__(self, provider_config, cluster_name):
         NodeProvider.__init__(self, provider_config, cluster_name)
         self.cluster_name = cluster_name
-        self.namespace = provider_config["namespace"]["metadata"]["name"]
+        self.namespace = provider_config["namespace"]
 
     def non_terminated_nodes(self, tag_filters):
         # Match pods that are in the 'Pending' or 'Running' phase.
@@ -34,6 +34,7 @@ def non_terminated_nodes(self, tag_filters):
             "status.phase!=Failed",
             "status.phase!=Unknown",
             "status.phase!=Succeeded",
+            "status.phase!=Terminating",
         ])
 
         tag_filters[TAG_RAY_CLUSTER_NAME] = self.cluster_name