Skip to content

Fix segmentation fault when calling ray.put on a dictionary with object keys #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2017
Merged

Fix segmentation fault when calling ray.put on a dictionary with object keys #548

merged 4 commits into from
May 15, 2017

Conversation

ericl
Copy link
Contributor

@ericl ericl commented May 14, 2017 •
edited by robertnishihara
Loading

The fix is similar to f468871. In this case, dicts as keys are not supported by python, but we might end up with them during key pickling.

This fixes #543.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@robertnishihara
Copy link
Collaborator

ok to test

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/769/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/770/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/780/
Test PASSed.

@pcmoritz pcmoritz merged commit e2e9e4c into ray-project:master May 15, 2017
@robertnishihara robertnishihara mentioned this pull request May 15, 2017
Closed
Myasuka pushed a commit to Myasuka/ray that referenced this pull request Aug 11, 2025
@Chong-Li
[Autoscaler v2] Autoscaler submits scale request to kuberay operator (r…
c794ac3 
…ay-project#548)

* autoscaler to kuberay

Signed-off-by: Chong Li <lc300133@antgroup.com>

* Add on/off switch

Signed-off-by: Chong Li <lc300133@antgroup.com>

* Temporary test

Signed-off-by: Chong Li <lc300133@antgroup.com>

* Temp test

Signed-off-by: Chong Li <lc300133@antgroup.com>

* Add log

Signed-off-by: Chong Li <lc300133@antgroup.com>

---------

Signed-off-by: Chong Li <lc300133@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when calling ray.put on a dictionary with object keys
4 participants
@ericl @AmplabJenkins @robertnishihara @pcmoritz