Skip to content

[llm] bump vllm to 0.9.0.1 #53443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 9, 2025
Merged

Conversation

lk-chen
Copy link
Contributor

@lk-chen lk-chen commented May 30, 2025

Why are these changes needed?

Many important reasons

  1. P/D disaggregation feature is added in 0.9.0
  2. There's this dependency chain: vllm0.8.5 -> opentelemetry1.26.0 -> protobuf3, ray wants to upgrade to protobuf4
  • vllm0.9.0 allows opentelemetry 1.27, which accepts protobuf4
  1. some users want vllm 0.9.0

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@lk-chen lk-chen requested review from a team as code owners May 30, 2025 17:46
@eicherseiji
Copy link
Contributor

eicherseiji commented May 30, 2025

@lk-chen Can we change the import path here:

# python/ray/llm/_internal/serve/deployments/llm/vllm/vllm_engine.py
        if self.llm_config.log_engine_metrics:
            from ray.llm._internal.serve.deployments.llm.vllm.vllm_loggers import (
                RayPrometheusStatLogger,
            )

            # V1 AsyncLLMEngine does not yet support add_logger
            # For now, assume folks enabling log_engine_metrics do not require LoggingStatLogger, PrometheusStatLogger
            custom_stat_loggers = [RayPrometheusStatLogger]

From

            from ray.llm._internal.serve.deployments.llm.vllm.vllm_loggers import (

to

            from vllm.v1.metrics.ray_wrappers import (

and delete python/ray/llm/_internal/serve/deployments/llm/vllm/vllm_loggers.py?

release/llm_tests/serve/test_llm_serve_integration.py would have to be changed as well. Lmk if it's easier for me to just upload a patch.

@eicherseiji eicherseiji self-assigned this May 30, 2025
@eicherseiji
Copy link
Contributor

Taking this over

@lk-chen lk-chen changed the title [llm] bump vllm to 0.9.0 [llm] bump vllm to 0.9.0.1 Jun 2, 2025
@eicherseiji eicherseiji added the go add ONLY when ready to merge, run all tests label Jun 3, 2025
@eicherseiji
Copy link
Contributor

Workarounds in this PR:

Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of qs before we merge.

@@ -162,6 +167,17 @@ def test_vllm_llama_lora():
assert all("resp" in out for out in outs)


@ray.remote(num_gpus=1)
def delete_torch_compile_cache_on_worker():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that if I run the script using compiled graph twice in a row the second one will die because of this hythersis effect?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah; I think pytest isn't letting the engine/pytorch clean up correctly between parameterizations so this is the workaround.

lk-chen and others added 17 commits June 8, 2025 08:41
Signed-off-by: Linkun Chen <github@lkchen.net>
Signed-off-by: Linkun Chen <github@lkchen.net>
Signed-off-by: Linkun Chen <github@lkchen.net>
Signed-off-by: Linkun Chen <github@lkchen.net>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
@kouroshHakha kouroshHakha merged commit a872286 into ray-project:master Jun 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants