[Asyncio] Allow Async_API to init when loop is running #5323

simon-mo · 2019-07-30T21:08:39Z

Two changes were made:

Make sure ray cluster is initialized before calling init()
If the loop is already running _async_init is scheduled to run in current loop.

Linter

I've run scripts/format.sh to lint the changes in this PR.

AmplabJenkins · 2019-07-31T00:17:58Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15809/
Test FAILed.

pcmoritz

Thanks for fixing this! In the future we should get rid of the async init and just call it automatically when the first async operation is used.

)

simon-mo added 5 commits July 30, 2019 12:55

Assert ray is initialized

d37beda

Make sure ray is initialized

4ccf246

Make sure ray is initialized before asyncio init

7eb2f29

Use ensure_future to schedule coroutine if loop is running

c6d6ec3

Format code

095964e

simon-mo requested review from suquark and pcmoritz July 30, 2019 21:08

pcmoritz approved these changes Jul 31, 2019

View reviewed changes

pcmoritz merged commit d762379 into ray-project:master Jul 31, 2019

edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019

[Asyncio] Allow Async_API to init when loop is running (ray-project#5323

b64b341

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Asyncio] Allow Async_API to init when loop is running #5323

[Asyncio] Allow Async_API to init when loop is running #5323

simon-mo commented Jul 30, 2019

AmplabJenkins commented Jul 31, 2019

pcmoritz left a comment

[Asyncio] Allow Async_API to init when loop is running #5323

[Asyncio] Allow Async_API to init when loop is running #5323

Conversation

simon-mo commented Jul 30, 2019

Linter

AmplabJenkins commented Jul 31, 2019

pcmoritz left a comment

Choose a reason for hiding this comment