Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure learner queue timeout #5270

Merged
merged 5 commits into from
Jul 26, 2019
Merged

configure learner queue timeout #5270

merged 5 commits into from
Jul 26, 2019

Conversation

antoine-galataud
Copy link
Contributor

What do these changes do?

Makes learner queue timeout configurable for async samples optimizer.

Related issue number

Closes #5260

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15640/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1814/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1815/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15641/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1819/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15646/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1823/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15650/
Test PASSed.

ericl
ericl reviewed Jul 25, 2019
View reviewed changes
python/ray/rllib/tests/test_optimizers.py
@@ -117,26 +117,26 @@ def setUpClass(cls):
ray.init(num_cpus=8)

def testSimple(self):
local, remotes = self._make_evs()
local, remotes = self._make_envs()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically these aren't envs -- perhaps "_make_workers"?

ericl
ericl approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a comment. The reason the timeout is needed is to avoid indefinite hangs should sampling crash, so it's probably a bug that the async replay optimizer doesn't have a timeout.

@ericl ericl self-assigned this Jul 25, 2019
@ericl ericl merged commit 8276182 into ray-project:master Jul 26, 2019
edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019
@antoine-galataud @edoakes
[rllib] Configure learner queue timeout (ray-project#5270)
19b44d0 
* configure learner queue timeout

* lint

* use config

* fix method args order, add unit test

* fix wrong param name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rllib] Slow env raises learner queue timeout
3 participants
@antoine-galataud @AmplabJenkins @ericl