[rllib] Move some inline defs to avoid deserialization errors #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only thing I can think of is perhaps the import thread timing compared to task execution is different after the GCS pr (e.g., tasks get executed before the import finishes). |
|
Test PASSed. |
raulchen
approved these changes
Jul 19, 2019
|
Test FAILed. |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 25, 2019
…oject#5228) * fix bug * move metrics too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I'm still not sure why the definition order of these classes matter, or why the protobuf refactoring PR causes it to matter. However, this PR does empirically fix the IMPALA crashes when remote_worker_envs=True and the number of workers is overloaded on the machine.
Related issue number
Closes #5125
Linter
scripts/format.shto lint the changes in this PR.