Skip to content

[core] Add more compilation options for C++ hardening #51857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025
Merged

[core] Add more compilation options for C++ hardening #51857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8343fcd
Add more compilation options for C++ hardening
dentiny Mar 31, 2025
eea2f2e
Merge branch 'master' into hjiang/compilation-options
dentiny Apr 1, 2025
d9fe6fc
disable warning for cython
dentiny Apr 1, 2025
80725cb
Merge branch 'hjiang/compilation-options' of github.com:dentiny/ray i…
dentiny Apr 1, 2025
a44b8d1
remove stack protector for prod
dentiny Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ test:segfault --run_under="bash -c 'unset GREP_OPTIONS && if ! grep -q -o Micros
build:debug -c dbg
build:debug --copt="-g"
build:debug --copt -fno-omit-frame-pointer
build:debug --copt -fstack-protector-strong
build:debug --copt -fcf-protection=full
build:debug --strip="never"

# Undefined Behavior Sanitizer
Expand Down
2 changes: 2 additions & 0 deletions bazel/ray.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ COPTS_WITHOUT_LOG = select({
"-Wunused-result",
"-Wconversion-null",
"-Wno-misleading-indentation",
"-Wimplicit-fallthrough",
],
}) + select({
"//:clang-cl": [
Expand All @@ -32,6 +33,7 @@ PYX_COPTS = select({
# Ignore this warning since CPython and Cython have issue removing deprecated tp_print on MacOS
"-Wno-deprecated-declarations",
"-Wno-shadow",
"-Wno-implicit-fallthrough",
Copy link
Contributor Author

@dentiny dentiny Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython is auto-generated code, cannot do anything.

],
}) + select({
"@platforms//os:windows": [
Expand Down