Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sgd] Deprecate old distributed SGD implementation #5160

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

pschafhalter
Copy link
Contributor

What do these changes do?

  • Removes old experimental SGD implementation

Related issue number

Closes #5093

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15273/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1583/
Test FAILed.

@richardliaw
Copy link
Contributor

does README of the repo need to change?

@richardliaw richardliaw self-assigned this Jul 10, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1594/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15284/
Test PASSed.

@ericl
Copy link
Contributor

ericl commented Jul 10, 2019

You also want to remove the jenkins tests from run_multi_node_tests.sh

@pschafhalter
Copy link
Contributor Author

You also want to remove the jenkins tests from run_multi_node_tests.sh

I think I removed those already in a previous PR since they were failing.

@richardliaw richardliaw merged commit fc58905 into ray-project:master Jul 22, 2019
@jichan3751 jichan3751 mentioned this pull request Jul 23, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SGD] Deprecate old TF SGD code
4 participants