Skip to content

[Doc] Update vllm example with metrics #51156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion doc/source/serve/doc_code/vllm_openai_example.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# __serve_example_begin__
from typing import Dict, Optional, List
from typing import Dict, Optional, List, Union
import logging

from fastapi import FastAPI
Expand All @@ -24,6 +24,7 @@
OpenAIServingModels,
)

from vllm.usage.usage_lib import UsageContext
from vllm.utils import FlexibleArgumentParser
from vllm.entrypoints.logger import RequestLogger

Expand All @@ -32,6 +33,17 @@
app = FastAPI()


def get_served_model_names(engine_args: AsyncEngineArgs) -> List[str]:
if engine_args.served_model_name is not None:
served_model_names: Union[str, List[str]] = engine_args.served_model_name
# Because the typing suggests it could be a string or list of strings
if isinstance(served_model_names, str):
served_model_names: List[str] = [served_model_names]
else:
served_model_names: List[str] = [engine_args.model]
return served_model_names


@serve.deployment(
autoscaling_config={
"min_replicas": 1,
Expand Down Expand Up @@ -60,6 +72,15 @@ def __init__(
self.request_logger = request_logger
self.chat_template = chat_template
self.engine = AsyncLLMEngine.from_engine_args(engine_args)
self.usage_context = UsageContext.ENGINE_CONTEXT
self.engine_config = self.engine_args.create_engine_config(self.usage_context)
served_model_names: List[str] = get_served_model_names(engine_args)
additional_metrics_logger: RayPrometheusStatLogger = RayPrometheusStatLogger(
local_interval=0.5,
labels=dict(model_name=served_model_names[0]),
vllm_config=self.engine_config,
)
self.engine.add_logger("ray", additional_metrics_logger)

@app.post("/v1/chat/completions")
async def create_chat_completion(
Expand Down