[core] Setup log rotation for runtime env agent #50877
Open
+98
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
force-pushed
the
hjiang/redirect-runtime-env-agent
branch
from
e10a3b5 to
993da3c
Compare
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
commented
Feb 25, 2025
| @@ -97,18 +99,16 @@ def open_capture_files(log_dir): | |||
| "--logging-rotate-bytes", | |||
| required=False, | |||
| type=int, | |||
| default=ray_constants.LOGGING_ROTATE_BYTES, | |||
| default=sys.maxsize, | |||
There was a problem hiding this comment.
The behavior here is tricky, we have two types of files here: runtime_agent.out and runtime_agent.log.
In terms of current behavior, default rotation size for out file is sys.maxsize;
while default value for log file is ray_constants.LOGGING_ROTATE_BYTES.
jjyao
reviewed
Feb 25, 2025
python/ray/_raylet.pyx
Outdated
| RedirectStderr(opt) | ||
|
|
||
| @staticmethod | ||
| def redirect_stdout(const c_string &file_path, uint64_t rotation_max_size, uint64_t rotation_max_file_count, c_bool tee_to_stdout, c_bool tee_to_stderr): |
There was a problem hiding this comment.
what's the difference between this and the previous redirect_stdout?
There was a problem hiding this comment.
No difference.. I'm really surprised it could compile
Signed-off-by: dentiny <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled, use pipe-based redirection to setup log rotation for runtime env agent.