[train v2] Fix trainer import deserialization when captured within a Ray tasks #50862
+49
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid imports from
ray.train.torch
in theTorchTrainer
definition file since it causes circular import errors when captured in the scope of Ray tasks.The following script errors at the moment with a circular import error when the
TorchTrainer
class gets deserialized on the task/actor that captured it. This is also an issue for the Tune + Train integration because the Tune function trainable gets run as a Ray actor task, which would capture the imported class.