[serve.llm] remove backoff dependency #50822
Merged
+230
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
GeneDer
reviewed
Feb 22, 2025
python/ray/llm/_internal/serve/deployments/llm/multiplex/lora_model_loader.py
Outdated
Show resolved
Hide resolved
python/ray/llm/_internal/serve/deployments/llm/multiplex/lora_model_loader.py
Outdated
Show resolved
Hide resolved
GeneDer
approved these changes
Feb 25, 2025
| def test_retry_success_first_try(): | ||
| """Test that the function works normally when no exceptions occur.""" | ||
| # Create a mock function that doesn't raise exceptions | ||
| mock_fn = Mock(return_value="success") |
There was a problem hiding this comment.
Non-blocker: Would prefer not to just those mock/ patch when can. It's really simply to just write a function to do exactly return success and such 🙃
It's me and my friend :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove backoff from ray.serve.llm dependency.