Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][cgraph] Revive max_buffered_result arg #50725

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

ruisearch42
Copy link
Contributor

@ruisearch42 ruisearch42 commented Feb 19, 2025

Why are these changes needed?

#49565 merged max_buffered_results and max_inflight_executions for conciseness of the arg list. After further discussion, we'd like to keep these two args separate for finer-grained control of the compiled graph behavior.

Related issue number

Closes #50381

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@ruisearch42 ruisearch42 changed the title wip [core][cgraph] Revive max_buffered_result arg Feb 19, 2025
@ruisearch42 ruisearch42 added the go add ONLY when ready to merge, run all tests label Feb 19, 2025
@ruisearch42 ruisearch42 marked this pull request as ready for review February 19, 2025 18:26
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@jjyao jjyao merged commit 0bc8770 into ray-project:master Feb 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core][compiled graphs] Ray 2.42 got RayCgraphCapacityExceeded in vLLM
4 participants