Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray.serve.llm] Fix setting up AutoProcessor #50715

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Feb 19, 2025

Why are these changes needed?

Was doing an end to end test and found out a different AutoProcessor was set on the vllm engine start vs used in the vlllm deployment. Remove the deep copy on llm_config during constructing of the vllm engine and moved set_processor call into apply_checkpoint_info. Also start to use real vllm engine in testing_model which is used by test_openai_compatibility.py to catch those types of issues.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
… engine in the test

Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer marked this pull request as ready for review February 19, 2025 05:11
@GeneDer GeneDer requested a review from a team as a code owner February 19, 2025 05:11
@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Feb 19, 2025
@GeneDer
Copy link
Contributor Author

GeneDer commented Feb 19, 2025

Seeing this working end2end in a workspace
image

Signed-off-by: Gene Su <e870252314@gmail.com>
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kouroshHakha kouroshHakha changed the title [LLM] Fix setting up AutoProcessor [ray.serve.llm] Fix setting up AutoProcessor Feb 19, 2025
@kouroshHakha kouroshHakha enabled auto-merge (squash) February 19, 2025 05:36
… e2e release test

Signed-off-by: Gene Su <e870252314@gmail.com>
@github-actions github-actions bot disabled auto-merge February 19, 2025 07:52
@kouroshHakha kouroshHakha enabled auto-merge (squash) February 19, 2025 08:04
@kouroshHakha kouroshHakha merged commit 179af97 into ray-project:master Feb 19, 2025
6 checks passed
@GeneDer GeneDer deleted the fix-setting-processor branch February 20, 2025 00:50
israbbani pushed a commit that referenced this pull request Feb 25, 2025
Signed-off-by: Gene Su <e870252314@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants