Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add back workflow test #50660

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Feb 17, 2025

Why are these changes needed?

The test seems to work now.

Related issue number

Closes #50193

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Feb 17, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah marked this pull request as ready for review February 18, 2025 17:10
@dayshah dayshah requested a review from jjyao February 18, 2025 17:11
@jjyao jjyao merged commit 5592700 into ray-project:master Feb 18, 2025
5 checks passed
@dayshah dayshah deleted the fix-workflow-test branch February 18, 2025 20:36
400Ping pushed a commit to 400Ping/ray that referenced this pull request Feb 20, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
israbbani pushed a commit that referenced this pull request Feb 25, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test linux://python/ray/workflow:tests/test_events_with_crash is consistently_failing
2 participants