Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] Simplify Operator.__repr__ #50620

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Conversation

raulchen
Copy link
Contributor

Why are these changes needed?

Currently, Operator.__repr__ prints the full DAG. It's too verbose.
Simplify it to only print the current operator. Added dag_string for the full DAG.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen requested a review from a team as a code owner February 14, 2025 20:46
@raulchen raulchen added the go add ONLY when ready to merge, run all tests label Feb 14, 2025
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to update this line to use dag_string:

logger.info(f"Execution plan of Dataset: {dag}")

LGTM otherwise

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen enabled auto-merge (squash) February 15, 2025 04:00
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@github-actions github-actions bot disabled auto-merge February 19, 2025 18:08
@raulchen raulchen merged commit 5ca12f9 into ray-project:master Feb 19, 2025
5 checks passed
@raulchen raulchen deleted the op-repr branch February 19, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants