[Feat][Dashboard] Remove StateHead's dependencies on DataSource #50605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
…ll_node_info. Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
…tatehead Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
force-pushed
the
feature/remove-statehead-deps-on-datasource
branch
from
5176d7a to
e2e85c1
Compare
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
changed the title
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
jjyao
reviewed
Feb 25, 2025
Comment on lines
366
to
368
| all_node_info_reply = await self._client.get_all_node_info( | ||
| timeout=option.timeout, limit=None | ||
| ) |
There was a problem hiding this comment.
we should filter ALIVE nodes, like line 485?
There was a problem hiding this comment.
Actually get_all_node_info accepts a filters argument so we can let GCS only returns ALIVE nodes.
There was a problem hiding this comment.
Addressed in daa21d8.
I also found that the filter does not support filter node_info.runtime_env_agent_port is not None. So for this one I still use list comprehension.
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Based on #50122
Related issue number
N/A
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.