[core] Implement dup2 wrapper #50439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
force-pushed
the
hjiang/dup2-with-restore
branch
from
2fa5410 to
75db43a
Compare
Signed-off-by: hjiang <hjiang@anyscale.com>
jjyao
reviewed
Feb 12, 2025
src/ray/util/BUILD
Outdated
Comment on lines
333
to
334
| "@platforms//os:windows": ["dup2_wrapper_windows.cc"], | ||
| "//conditions:default": ["dup2_wrapper_posix.cc"], |
There was a problem hiding this comment.
What's the difference between this approach and the other approach the current codebase is using which is ifdef
There was a problem hiding this comment.
No difference,
selectclause works at file level,ifdefworks at source code level- I use
selecthere because implementation for two platforms are completely different and almost nothing to share
Signed-off-by: dentiny <dentinyhao@gmail.com>
jjyao
reviewed
Feb 12, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
…o hjiang/dup2-with-restore
Signed-off-by: dentiny <dentinyhao@gmail.com>
|
@jjyao The failed CI test has nothing to do with my change, which hasn't been integrated with python yet. |
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
|
@jjyao This PR should be good to go, the only change related to windows platform is C++ side unit tests, which already passed. I don't know why my CI gets stuck for a day. |
|
Hi @jjyao I think this PR should be good to go. |
Signed-off-by: dentiny <dentinyhao@gmail.com>
|
The failed |
jjyao
approved these changes
Feb 28, 2025
VamshikShetty
pushed a commit
to VamshikShetty/ray
that referenced
this pull request
Mar 3, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: vs030455 <vamshikdshetty@gmail.com>
Michaelhess17
pushed a commit
to Michaelhess17/ray
that referenced
this pull request
Mar 3, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>
jaychia
pushed a commit
to jaychia/ray
that referenced
this pull request
Mar 19, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's used in logging redirection to achieve
dup2