-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib; docs] Docs do-over (new API stack): Remove special "new API stack" page (move some of its content to migration guide). #49713
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Small add.
If you set this to 0, your LearnerGroup only contains a **local** Learner that runs on the main | ||
process (and shares the compute resources with that process, usually 1 CPU). | ||
If you set this to ``0``, your LearnerGroup only contains a **local** Learner that runs on the main | ||
process and shares its compute resources, typically 1 CPU. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add here that for Offline RL this setting should be never 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some style nits. Sorry you had to correct all the single quotes to double quotes for the code font. I think I did those.
@@ -38,7 +38,7 @@ AlgorithmConfig and Algorithm | |||
.. tip:: | |||
The following is a quick overview of **RLlib AlgorithmConfigs and Algorithms**. | |||
See :ref:`here for a detailed description of the Algorithm class <rllib-algorithms-doc>`. | |||
See here for a :ref:`detailed description of the Algorithm class <rllib-algorithms-doc>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here for a :ref:`detailed description of the Algorithm class <rllib-algorithms-doc>`. | |
See :ref:`<rllib-algorithms-doc>` for a detailed description of the Algorithm class. |
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Sven Mika <sven@anyscale.io>
Docs do-over (new API stack):
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.